Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align process command arguments to spec defenition #4032

Merged
merged 8 commits into from
Jul 11, 2024
Merged

fix: align process command arguments to spec defenition #4032

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
21f6c64
fix: align process command arguments to spec defenition
tamirdavid Jul 5, 2024
46f614b
update change log
tamirdavid Jul 9, 2024
20ffaa3
Merge branch 'main' into align-proc-args-to-spec-definition
tamirdavid Jul 9, 2024
ca872d3
Merge branch 'main' into align-proc-args-to-spec-definition
lzchen Jul 9, 2024
f718268
Merge branch 'main' into align-proc-args-to-spec-definition
lzchen Jul 9, 2024
eb375ec
Update CHANGELOG.md
tamirdavid Jul 10, 2024
4ccdae3
Update CHANGELOG.md
xrmx Jul 10, 2024
1e4507a
Merge branch 'main' into align-proc-args-to-spec-definition
tamirdavid Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ def detect(self) -> "Resource":
_process_executable_path = os.path.dirname(_process_executable_name)
_process_command = sys.argv[0]
_process_command_line = " ".join(sys.argv)
_process_command_args = sys.argv[1:]
_process_command_args = sys.argv
resource_info = {
PROCESS_RUNTIME_DESCRIPTION: sys.version,
PROCESS_RUNTIME_NAME: sys.implementation.name,
Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-sdk/tests/resources/test_resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ def test_process_detector(self):
)
self.assertEqual(
aggregated_resource.attributes[PROCESS_COMMAND_ARGS],
tuple(sys.argv[1:]),
tuple(sys.argv),
)

def test_resource_detector_entry_points_default(self):
Expand Down