-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing example requirements #4000
Add missing example requirements #4000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a pip install opentelemetry-api opentelemetry-sdk opentelemetry-exporter-otlp
to the README instead so we don't add another place where we need to bump the versions
I tried to align with the other examples, which all have requirements.txt files. I don't have a preference for either, so I am happy to change it to simply adding it to the readme. |
Given the status of these requirements I think I have a stronger opinion now 😅 But let's see what maintainers think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we are not bumping the packages versions on requirements.txt for those examples, this explain why we have some requirements.txt file with opentelemetry-sdk=1.15.0
.
+1 for this, less maintenence the better :) |
I suggest we keep the |
I updated it to use |
We don't requirements.txt file for the examples. Do we really want to start adding them for each example? This seems like more maintenance overhead. |
I was looking at the other examples in that folder (https://github.com/open-telemetry/opentelemetry-python/tree/main/docs/examples/metrics/views, https://github.com/open-telemetry/opentelemetry-python/tree/main/docs/examples/metrics/reader, https://github.com/open-telemetry/opentelemetry-python/tree/main/docs/examples/metrics/prometheus-grafana) which all have a |
Oh apologies, was referring to the other folders. If every other example in metrics has requirements.txt i don't mind adding this. |
Changed it to use |
Needs another rebase. Might want to change the permissions of the pr to allow maintainer edits so we can rebase for you next time :) |
645cf39
to
17a4426
Compare
Ah, the organization fork does not have that automatically. I enabled the maintainer modification access now and rebased it |
Description
Adds missing
requirements.txt
for one example (https://github.com/open-telemetry/opentelemetry-python/tree/main/docs/examples/metrics/instruments).Type of change
How Has This Been Tested?
pip install -r requirements.txt python example.py # this is already part of the docs
Does This PR Require a Contrib Repo Change?
Checklist:
Changelogs have been updatedUnit tests have been addedDocumentation has been updated