Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate lint into several jobs #3902

Merged
merged 7 commits into from
Jul 11, 2024
Merged

Separate lint into several jobs #3902

merged 7 commits into from
Jul 11, 2024

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented May 6, 2024

Fixes #3887

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 6, 2024
@ocelotl ocelotl self-assigned this May 6, 2024
@ocelotl ocelotl requested a review from a team May 6, 2024 17:48
@ocelotl ocelotl marked this pull request as draft May 6, 2024 17:49
@ocelotl ocelotl force-pushed the issue_3887 branch 2 times, most recently from 07eb44a to a9e2fb7 Compare May 6, 2024 20:43
@ocelotl ocelotl changed the title WIP Separate lint into several jobs May 6, 2024
@ocelotl ocelotl force-pushed the issue_3887 branch 3 times, most recently from 161873e to bb8118a Compare May 6, 2024 21:50
@ocelotl ocelotl marked this pull request as ready for review May 6, 2024 21:50
@ocelotl ocelotl marked this pull request as draft May 6, 2024 21:51
@ocelotl ocelotl marked this pull request as ready for review June 11, 2024 20:50
lzchen
lzchen reviewed Jun 12, 2024
View reviewed changes
.github/workflows/lint.yml Outdated Show resolved Hide resolved
lzchen
lzchen reviewed Jun 12, 2024
View reviewed changes
.github/workflows/lint.yml Outdated Show resolved Hide resolved
lzchen
lzchen reviewed Jun 12, 2024
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
lzchen
lzchen reviewed Jun 12, 2024
View reviewed changes
tox.ini Show resolved Hide resolved
@xrmx
Copy link
Contributor

xrmx commented Jun 13, 2024 •
edited
Loading

Do we really want to do this without the parallelization benefits that we got in -contrib?

xrmx
xrmx reviewed Jun 18, 2024
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
emdneto
emdneto reviewed Jul 2, 2024
View reviewed changes
tox.ini Show resolved Hide resolved
@ocelotl ocelotl mentioned this pull request Jul 2, 2024
Closed
@ocelotl
Copy link
Contributor Author

ocelotl commented Jul 2, 2024

Do we really want to do this without the parallelization benefits that we got in -contrib?

We will get the same parallelization benefits here since we will be creating more, smaller lint jobs instead of having just a big one.

@ocelotl ocelotl requested review from xrmx, lzchen and emdneto July 2, 2024 23:29
@lzchen
Copy link
Contributor

lzchen commented Jul 3, 2024

@ocelotl

Apologies for the delay in this pr. I want to bring it up one more time during the SIG to get the final opinions about it before approving.

@ocelotl ocelotl merged commit 5dc48c5 into open-telemetry:main Jul 11, 2024
285 checks passed
@ocelotl ocelotl deleted the issue_3887 branch July 11, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@xrmx xrmx Awaiting requested review from xrmx

@emdneto emdneto Awaiting requested review from emdneto

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint is very slow
4 participants
@ocelotl @xrmx @lzchen @emdneto