Implement client key file and client certificate file for all OTLP exporters. #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chittalpatel
force-pushed
the
2991-client-key-and-certificate-for-otlp-exporters
branch
from
a685836 to
39bc279
Compare
chittalpatel
changed the title
chittalpatel
changed the title
chittalpatel
force-pushed
the
2991-client-key-and-certificate-for-otlp-exporters
branch
from
39bc279 to
e57aa8e
Compare
ocelotl
added
the
Approve Public API check
chittalpatel
force-pushed
the
2991-client-key-and-certificate-for-otlp-exporters
branch
from
e57aa8e to
6bef4e6
Compare
…ertificate-for-otlp-exporters
|
I would be interested in this feature. Are you still working on this? |
xrmx
reviewed
Apr 8, 2024
| @@ -89,6 +89,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ([#3524](https://github.com/open-telemetry/opentelemetry-python/pull/3524)) | |||
| - Handle `taskName` `logrecord` attribute | |||
| ([#3557](https://github.com/open-telemetry/opentelemetry-python/pull/3557)) | |||
| - Implement client key file and client certificate file for all OTLP exporters | |||
There was a problem hiding this comment.
This needs to be moved to unreleased above
|
Also interested in this. Is MTLS not supported on all exporters? I'm running into this problem a few times today with Node JS http exporter also |
This was referenced Aug 11, 2024
emdneto
reviewed
Aug 12, 2024
There was a problem hiding this comment.
@chittalpatel gentle ping. Are you still working on this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support to provide client key file and client certificate file to all OTLP exporters.
Fixes #2991
Fixes #3327
Type of change
How Has This Been Tested?
Updated tests and verified them using:
tox -e opentelemetry-exporter-otlp-proto-grpctox -e opentelemetry-exporter-otlp-proto-httpDoes This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
Checklist: