Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate contrib jobs per instrumentation #3507

Merged
merged 7 commits into from
Jan 5, 2024

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Nov 3, 2023

Reopening after #3500 with a fix in the yaml file.

@ocelotl ocelotl self-assigned this Nov 3, 2023
@ocelotl ocelotl requested a review from a team November 3, 2023 23:06
@ocelotl
Copy link
Contributor Author

ocelotl commented Nov 3, 2023

@trask test cases seem to be running now 👍

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 3, 2023
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will number of jobs create any problem?

@ocelotl
Copy link
Contributor Author

ocelotl commented Nov 6, 2023

Will number of jobs create any problem?

It is a large number of jobs, but they seem to be running fine. For some reason 60 jobs are stuck in "Expected — Waiting for status to be reported" status even when these jobs are no longer defined in the workflow file.

@trask
Copy link
Member

trask commented Nov 6, 2023

For some reason 60 jobs are stuck in "Expected — Waiting for status to be reported" status even when these jobs are no longer defined in the workflow file.

it looks like these are "Required" status checks, you'll probably need to update the branch protections

(we've found this strategy useful in the Java repos: https://github.com/trask/repository-practices/blob/main/docs/general-github-actions-practices.md#have-a-single-required-status-check-for-pull-requests)

@ocelotl
Copy link
Contributor Author

ocelotl commented Nov 6, 2023

For some reason 60 jobs are stuck in "Expected — Waiting for status to be reported" status even when these jobs are no longer defined in the workflow file.

it looks like these are "Required" status checks, you'll probably need to update the branch protections

(we've found this strategy useful in the Java repos: trask/repository-practices@main/docs/general-github-actions-practices.md#have-a-single-required-status-check-for-pull-requests)

Ah, that's right fixing..., thanks @trask !

@ocelotl ocelotl merged commit 975733c into open-telemetry:main Jan 5, 2024
312 checks passed
@ocelotl ocelotl deleted the issue_3499 branch January 5, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants