Fix missing wsgi dependency

[codeboten]

Description

A missing dependency in tox was causing the getting-started task to fail, this fixes that.

Does This PR Require a Contrib Repo Change?

• Yes. - Link to PR: Fix failing aiopg tests opentelemetry-python-contrib#317
• No.

[srikanthccv]

I am not sure why it isn't failing but tracecontext test also needs wsgi as dependency?

[codeboten]

That's a good point... i wonder if it's using the tox cache which would have the dependency in it already, maybe this would explain why this other tox target didn't fail before either

[codeboten]

Actually looking at the tracecontext job, i don't see it requiring the flask instrumentation, am i missing something?

[srikanthccv]

It doesn't need flask instrumentation. It requires OpenTelemetryMiddleware from opentelemetry-instrumentation-wsgi.

[srikanthccv]

To give more context OpenTelemetryMiddleware doesn't exist in util-http and ideally this import should fail;

opentelemetry-python/tests/w3c_tracecontext_validation_server.py

Lines 33 to 49 in 731f32c

	from opentelemetry.util.http.wsgi import OpenTelemetryMiddleware
	# FIXME This could likely be avoided by integrating this script into the
	# standard test running mechanisms.
	# Integrations are the glue that binds the OpenTelemetry API and the
	# frameworks and libraries that are used together, automatically creating
	# Spans and propagating context as appropriate.
	trace.set_tracer_provider(TracerProvider())
	RequestsInstrumentor().instrument()
	# SpanExporter receives the spans and send them to the target location.
	span_processor = SimpleExportSpanProcessor(ConsoleSpanExporter())
	trace.get_tracer_provider().add_span_processor(span_processor)
	app = flask.Flask(__name__)
	app.wsgi_app = OpenTelemetryMiddleware(app.wsgi_app)

no idea how it is working, as mentioned earlier probably some cache but needs some investigation.

[ocelotl]

To give more context OpenTelemetryMiddleware doesn't exist in util-http and ideally this import should fail;

opentelemetry-python/tests/w3c_tracecontext_validation_server.py

Lines 33 to 49 in 731f32c

	from opentelemetry.util.http.wsgi import OpenTelemetryMiddleware
	# FIXME This could likely be avoided by integrating this script into the
	# standard test running mechanisms.
	# Integrations are the glue that binds the OpenTelemetry API and the
	# frameworks and libraries that are used together, automatically creating
	# Spans and propagating context as appropriate.
	trace.set_tracer_provider(TracerProvider())
	RequestsInstrumentor().instrument()
	# SpanExporter receives the spans and send them to the target location.
	span_processor = SimpleExportSpanProcessor(ConsoleSpanExporter())
	trace.get_tracer_provider().add_span_processor(span_processor)
	app = flask.Flask(__name__)
	app.wsgi_app = OpenTelemetryMiddleware(app.wsgi_app)

no idea how it is working, as mentioned earlier probably some cache but needs some investigation.

I guess this file is not being imported at all when running tox, checking that...

[codeboten]

Thanks for catching this @lonewolf3739, fixed and found one more missed reference in the docs

[ocelotl]

To give more context OpenTelemetryMiddleware doesn't exist in util-http and ideally this import should fail;

opentelemetry-python/tests/w3c_tracecontext_validation_server.py

Lines 33 to 49 in 731f32c

	from opentelemetry.util.http.wsgi import OpenTelemetryMiddleware
	# FIXME This could likely be avoided by integrating this script into the
	# standard test running mechanisms.
	# Integrations are the glue that binds the OpenTelemetry API and the
	# frameworks and libraries that are used together, automatically creating
	# Spans and propagating context as appropriate.
	trace.set_tracer_provider(TracerProvider())
	RequestsInstrumentor().instrument()
	# SpanExporter receives the spans and send them to the target location.
	span_processor = SimpleExportSpanProcessor(ConsoleSpanExporter())
	trace.get_tracer_provider().add_span_processor(span_processor)
	app = flask.Flask(__name__)
	app.wsgi_app = OpenTelemetryMiddleware(app.wsgi_app)

no idea how it is working, as mentioned earlier probably some cache but needs some investigation.

I guess this file is not being imported at all when running tox, checking that...

Yes, that file is not part of any tox-related test.

[codeboten]

that file gets run as part of the tracecontext job

[srikanthccv]

Where is this commit from? I couldn't find this in recent main commits?

[codeboten]

It's in the contrib PR linked in the description

[srikanthccv]

Alright, I was thinking may be this SHA was the reason, Probably not.