Skip to content

Commit

Permalink
schema (#3454)
Browse files Browse the repository at this point in the history
  • Loading branch information
lzchen authored Oct 2, 2023
1 parent 495d705 commit 7f8c75d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#3447](https://github.com/open-telemetry/opentelemetry-python/pull/3447))
- Update semantic conventions to version 1.21.0
([#3251](https://github.com/open-telemetry/opentelemetry-python/pull/3251))
- Add missing schema_url in global api for logging and metrics
([#3251](https://github.com/open-telemetry/opentelemetry-python/pull/3251))

## Version 1.20.0/0.41b0 (2023-09-04)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ def get_logger(
instrumenting_module_name: str,
instrumenting_library_version: str = "",
logger_provider: Optional[LoggerProvider] = None,
schema_url: Optional[str] = None,
) -> "Logger":
"""Returns a `Logger` for use within a python process.
Expand All @@ -226,5 +227,5 @@ def get_logger(
if logger_provider is None:
logger_provider = get_logger_provider()
return logger_provider.get_logger(
instrumenting_module_name, instrumenting_library_version
instrumenting_module_name, instrumenting_library_version, schema_url
)
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,7 @@ def get_meter(
name: str,
version: str = "",
meter_provider: Optional[MeterProvider] = None,
schema_url: Optional[str] = None,
) -> "Meter":
"""Returns a `Meter` for use by the given instrumentation library.
Expand All @@ -729,7 +730,7 @@ def get_meter(
"""
if meter_provider is None:
meter_provider = get_meter_provider()
return meter_provider.get_meter(name, version)
return meter_provider.get_meter(name, version, schema_url)


def _set_meter_provider(meter_provider: MeterProvider, log: bool) -> None:
Expand Down

0 comments on commit 7f8c75d

Please sign in to comment.