Skip to content

Commit

Permalink
add changelog and improve test
Browse files Browse the repository at this point in the history
  • Loading branch information
emdneto committed Aug 21, 2024
1 parent 8427bc5 commit 7372c93
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

- Make log sdk add `exception.message` to logRecord for exceptions whose argument
- Make log sdk add `exception.message` to logRecord for exceptions whose argument
is an exception not a string message
([#4122](https://github.com/open-telemetry/opentelemetry-python/pull/4122))
- Fix use of `link.attributes.dropped`, which may not exist
Expand All @@ -29,6 +29,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#4134](https://github.com/open-telemetry/opentelemetry-python/pull/4134))
- Implement Client Key and Certificate File Support for All OTLP Exporters
([#4116](https://github.com/open-telemetry/opentelemetry-python/pull/4116))
- Implement Client Key and Certificate File Support for All OTLP Exporters
([#4116](https://github.com/open-telemetry/opentelemetry-python/pull/4116))
- Remove `_start_time_unix_nano` attribute from `_ViewInstrumentMatch` in favor
of using `time_ns()` at the moment when the aggregation object is created
([#4137](https://github.com/open-telemetry/opentelemetry-python/pull/4137))

## Version 1.26.0/0.47b0 (2024-07-25)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class TestTimeAlign(TestCase):

# This delay is needed for these tests to pass when they are run in
# Windows.
delay = 0.0001
delay = 0.001

def test_time_align_cumulative(self):
reader = InMemoryMetricReader()
Expand Down Expand Up @@ -62,6 +62,8 @@ def test_time_align_cumulative(self):
.metrics[1]
.data.data_points
)
self.assertEqual(len(data_points_0_0), 2)
self.assertEqual(len(data_points_0_1), 2)

self.assertLess(
data_points_0_0[0].start_time_unix_nano,
Expand Down Expand Up @@ -112,6 +114,9 @@ def test_time_align_cumulative(self):
.data.data_points
)

self.assertEqual(len(data_points_1_0), 2)
self.assertEqual(len(data_points_1_1), 2)

self.assertLess(
data_points_1_0[0].start_time_unix_nano,
data_points_1_0[1].start_time_unix_nano,
Expand Down Expand Up @@ -191,6 +196,8 @@ def test_time_align_delta(self):
.metrics[1]
.data.data_points
)
self.assertEqual(len(data_points_0_0), 2)
self.assertEqual(len(data_points_0_1), 2)

self.assertLess(
data_points_0_0[0].start_time_unix_nano,
Expand Down Expand Up @@ -240,6 +247,8 @@ def test_time_align_delta(self):
.metrics[1]
.data.data_points
)
self.assertEqual(len(data_points_1_0), 2)
self.assertEqual(len(data_points_1_1), 2)

self.assertEqual(
data_points_1_0[0].start_time_unix_nano,
Expand Down

0 comments on commit 7372c93

Please sign in to comment.