Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added \Attribute::TARGET_PARAMETER to \OpenTelemetry\API\Instrumentation\SpanAttribute #1433

Conversation

ChrisLightfootWild
Copy link
Contributor

Fixes #1429

Although the added "test" might not be appropriate. Is there a better way to test this?

It just proves that phpstan is happy rather than asserting anything more concrete.

@ChrisLightfootWild ChrisLightfootWild requested a review from a team as a code owner November 15, 2024 23:56
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.64%. Comparing base (7b5cbb5) to head (5efb812).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1433      +/-   ##
============================================
- Coverage     73.66%   73.64%   -0.02%     
  Complexity     2685     2685              
============================================
  Files           387      387              
  Lines          7977     7977              
============================================
- Hits           5876     5875       -1     
- Misses         2101     2102       +1     
Flag Coverage Δ
8.1 73.33% <ø> (+0.10%) ⬆️
8.2 73.50% <ø> (+0.03%) ⬆️
8.3 73.49% <ø> (+0.03%) ⬆️
8.4 73.51% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/API/Instrumentation/SpanAttribute.php 100.00% <ø> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5cbb5...5efb812. Read the comment docs.

@brettmc brettmc merged commit 8857b0c into open-telemetry:main Nov 16, 2024
9 of 10 checks passed
@ChrisLightfootWild ChrisLightfootWild deleted the fix/SpanAttribute-target-parameter branch November 16, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Attribute-based hooking] SpanAttribute example does not align with the declared attribute target
2 participants