-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guard against possible false value from file_get_contents in Host.php #1430
guard against possible false value from file_get_contents in Host.php #1430
Conversation
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
Will follow-up on CLA asap |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1430 +/- ##
============================================
+ Coverage 73.55% 73.66% +0.10%
- Complexity 2683 2685 +2
============================================
Files 387 387
Lines 7975 7977 +2
============================================
+ Hits 5866 5876 +10
+ Misses 2109 2101 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@jspaetzel can you run php-cs-fixer to resolve its complaint? Otherwise LGTM and just waiting on CLA to be signed :) |
✔️ Thanks y'all! |
There's other circumstances besides is_file && is_readable when file_get_contents may return false. This is a defensive change to prevent TypeErrors when calling trim()