Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename phpdoc-to-github-pages to phpdoc-to-github-pages.yml #1425

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Nov 4, 2024

follow up to #1418, where I named the file without the required YML suffix

follow up to open-telemetry#1418, where I named the file without the required YML suffix
@svrnm svrnm requested a review from a team as a code owner November 4, 2024 14:54
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for opentelemetry-php canceled.

Name Link
🔨 Latest commit 02acdb1
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-php/deploys/6728f56ef0f1670008c22ee2

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.46%. Comparing base (39cc549) to head (02acdb1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1425      +/-   ##
============================================
- Coverage     73.55%   73.46%   -0.10%     
  Complexity     2683     2683              
============================================
  Files           387      387              
  Lines          7975     7973       -2     
============================================
- Hits           5866     5857       -9     
- Misses         2109     2116       +7     
Flag Coverage Δ
8.1 73.20% <ø> (-0.04%) ⬇️
8.2 73.42% <ø> (-0.06%) ⬇️
8.3 73.46% <ø> (-0.01%) ⬇️
8.4 73.42% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39cc549...02acdb1. Read the comment docs.

@bobstrecansky
Copy link
Collaborator

@svrnm - anything else you want us to do with this PR? Just merge?

@svrnm
Copy link
Member Author

svrnm commented Nov 4, 2024

@svrnm - anything else you want us to do with this PR? Just merge?

If that would be possible, yes. Testing github workflows is a nightmare. I also disabled it for pull requests since the goal should be a publication on commit to main

@brettmc brettmc merged commit ea908b1 into open-telemetry:main Nov 5, 2024
13 of 14 checks passed
@brettmc
Copy link
Collaborator

brettmc commented Nov 5, 2024

That's worked: https://open-telemetry.github.io/opentelemetry-php/

@svrnm svrnm deleted the svrnm-patch-1 branch November 5, 2024 10:01
@svrnm
Copy link
Member Author

svrnm commented Nov 5, 2024

thanks, let me add it to the website then :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants