Handle out-of-order destruction of Fibers/DebugScopes during final shutdown #1209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable warnings for missing calls to
::detach()
during the final shutdown phase if the scope is not destructed in the original fiber;DebugScope::__destruct()
might be called before the fiber is resumed / before finally blocks that::detach()
the scope are run.I wasn't able to create a simple reproducer; it happens for example with
amphp/file ^3.0
andtbachert/otel-async-revolt-adapter 0.1.1
.