Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jaeger Propagator #1188

Merged
merged 11 commits into from
Dec 15, 2023
Merged

Conversation

weslenteche
Copy link
Contributor

@weslenteche weslenteche commented Dec 11, 2023

  • Added Jaeger Progagator with tests.

Fixes #1187.

@weslenteche weslenteche requested a review from a team December 11, 2023 23:45
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #1188 (c764b98) into main (d376566) will increase coverage by 0.17%.
The diff coverage is 97.64%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1188      +/-   ##
============================================
+ Coverage     84.29%   84.47%   +0.17%     
- Complexity     2196     2225      +29     
============================================
  Files           282      285       +3     
  Lines          6245     6330      +85     
============================================
+ Hits           5264     5347      +83     
- Misses          981      983       +2     
Flag Coverage Δ
7.4 83.13% <97.64%> (+0.19%) ⬆️
8.0 84.40% <97.64%> (+0.18%) ⬆️
8.1 84.53% <97.64%> (+0.17%) ⬆️
8.2 84.53% <97.64%> (+0.17%) ⬆️
8.3 84.53% <97.64%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...on/Propagator/Jaeger/JaegerDebugFlagContextKey.php 100.00% <100.00%> (ø)
...K/Metrics/MetricExporter/ConsoleMetricExporter.php 0.00% <ø> (ø)
...sion/Propagator/Jaeger/JaegerBaggagePropagator.php 96.55% <96.55%> (ø)
...c/Extension/Propagator/Jaeger/JaegerPropagator.php 98.07% <98.07%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d376566...c764b98. Read the comment docs.

@weslenteche weslenteche requested review from brettmc and Nevay December 14, 2023 01:47
@weslenteche
Copy link
Contributor Author

@Nevay and @brettmc, could you review it again?

@weslenteche weslenteche requested a review from Nevay December 15, 2023 00:45
@brettmc brettmc merged commit d8827f9 into open-telemetry:main Dec 15, 2023
12 checks passed
@brettmc
Copy link
Collaborator

brettmc commented Dec 15, 2023

@brettmc
Copy link
Collaborator

brettmc commented Dec 15, 2023

@weslenteche thanks for your contribution! As a follow-up, could you scan the docs on opentelemetry.io to see if we need to mention this propagator there?

@weslenteche weslenteche deleted the jaeger-propagator branch December 16, 2023 00:00
@weslenteche
Copy link
Contributor Author

You're welcome, I'll check how other languages mention this propagator and if necessary I'll add the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Jaeger Propagator
3 participants