Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename XCloudTrace to CloudTrace #1142

Conversation

ynikitin-etsy
Copy link
Contributor

This is to fix the renaming of XCloudTrace to CloudTrace since the extension is named like the latter: https://github.com/opentelemetry-php/extension-propagator-cloudtrace

Context in this PR: #1132 (comment)

@ynikitin-etsy ynikitin-etsy requested a review from a team November 15, 2023 16:19
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #1142 (c3b162b) into main (d6c4c89) will increase coverage by 0.06%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1142      +/-   ##
============================================
+ Coverage     84.28%   84.35%   +0.06%     
  Complexity     2193     2193              
============================================
  Files           282      282              
  Lines          6224     6224              
============================================
+ Hits           5246     5250       +4     
+ Misses          978      974       -4     
Flag Coverage Δ
7.4 82.99% <50.00%> (+0.06%) ⬆️
8.0 84.27% <50.00%> (+0.06%) ⬆️
8.1 84.41% <50.00%> (+0.06%) ⬆️
8.2 84.41% <50.00%> (+0.06%) ⬆️
8.3 84.41% <50.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...sion/Propagator/CloudTrace/CloudTraceFormatter.php 82.35% <ø> (ø)
src/Extension/Propagator/CloudTrace/Utils.php 97.36% <ø> (ø)
...ion/Propagator/CloudTrace/CloudTracePropagator.php 84.37% <50.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6c4c89...c3b162b. Read the comment docs.

@ynikitin-etsy ynikitin-etsy force-pushed the ynikitin-etsy/rename-cloudtrace-propagator branch from 25187b6 to c3b162b Compare November 21, 2023 16:12
@brettmc brettmc merged commit a568dde into open-telemetry:main Nov 27, 2023
11 checks passed
@brettmc
Copy link
Collaborator

brettmc commented Nov 27, 2023

@brettmc
Copy link
Collaborator

brettmc commented Nov 27, 2023

released SDK 1.0.1 and propagator 0.0.2 containing these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants