Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel-sig-security - adding SBOM to builds #1136

Closed
wants to merge 1 commit into from

Conversation

bobstrecansky
Copy link
Collaborator

#otel-sig-security asked for SBOM to be added to builds. This PR adds it to our php actions. It may be too frequent, but we can ensure we have this for when we do our builds.

@bobstrecansky bobstrecansky requested a review from a team November 2, 2023 18:01
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1136 (d0b2087) into main (42a8b95) will not change coverage.
The diff coverage is n/a.

❗ Current head d0b2087 differs from pull request most recent head 6de09c9. Consider uploading reports for the commit 6de09c9 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1136   +/-   ##
=========================================
  Coverage     84.27%   84.27%           
  Complexity     2160     2160           
=========================================
  Files           279      279           
  Lines          6137     6137           
=========================================
  Hits           5172     5172           
  Misses          965      965           
Flag Coverage Δ
7.4 82.89% <ø> (ø)
8.0 84.20% <ø> (ø)
8.1 84.34% <ø> (ø)
8.2 84.34% <ø> (ø)
8.3 84.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a8b95...6de09c9. Read the comment docs.

@brettmc
Copy link
Collaborator

brettmc commented Nov 3, 2023

It ran in 4 seconds and looks to have found some PHP packages, which is a good start. The next question is: how do we surface this? (particularly given we don't do releases in this repo or in contrib)

@brettmc
Copy link
Collaborator

brettmc commented Nov 27, 2023

@bobstrecansky It looks like this is successfully generating an SBOM, and it claims to be uploading it as an artifact, but I can't see one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants