Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Fix featuregate usage in controller tests #3490

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[chore] Fix featuregate usage in controller tests #3490

wants to merge 1 commit into from
+55 −27

Commits on Nov 24, 2024

  1. [chore] Fix featuregate usage in controller tests 

    We haven't been unsetting feature gates in controller tests after ending
the test, leading to them being enabled for the duration of the test
suite. In one case, a test actually depended on this fact, and I needed
to set the gate in it explicitly.

Also switched to use the gates explicitly vs parsing flags.
    @swiatekm
    swiatekm committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    06a3156 View commit details
    Browse the repository at this point in the history