Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare release v0.111.0 #3351

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Oct 13, 2024

Description:

Link to tracking Issue(s):

Testing:

Documentation:
Preview: https://github.com/frzifus/opentelemetry-operator/blob/prepare-0.111.0/CHANGELOG.md#01110

@frzifus frzifus added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 13, 2024
@pavolloffay
Copy link
Member

PR can be rebased and added changelog for missing PRs.

@frzifus frzifus marked this pull request as ready for review October 16, 2024 08:21
@frzifus frzifus requested a review from a team as a code owner October 16, 2024 08:21
@frzifus frzifus requested a review from pavolloffay October 16, 2024 08:22
@pavolloffay
Copy link
Member

@frzifus I would like to get this one more PR in before the release - #3358

@frzifus
Copy link
Member Author

frzifus commented Oct 16, 2024

mh.. chainsaw/targetallocator-prometheuscr fails in step-01.

# 2024-10-16T12:13:47.805Z     warn    internal/transaction.go:128    Failed to scrape Prometheus endpoint
{
  "kind": "receiver",
  "name": "prometheus",
  "data_type": "metrics",
  "scrape_timestamp": 1729080827804,
  "target_labels": "{__name__=\"up\", container=\"otc-container\", endpoint=\"monitoring\", instance=\"10.244.0.12:8888\", job=\"prometheus-cr-collector-monitoring\", namespace=\"chainsaw-evolving-gecko\", pod=\"prometheus-cr-collector-0\", service=\"prometheus-cr-collector-monitoring\"}"
}	

@frzifus
Copy link
Member Author

frzifus commented Oct 16, 2024

@pavolloffay
Copy link
Member

There are CI failures :/

@frzifus
Copy link
Member Author

frzifus commented Oct 16, 2024

There are CI failures :/

Y, I think we should handle this in the defaulting webhook and upgrade routine too. 😄

Signed-off-by: Benedikt Bongartz <[email protected]>
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks about the changelog. We should try to ensure subtext messages for entries start with an additional newline. Then, when they're rendered in markdown, there's an actual line break in the entry, which looks much cleaner.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Mikołaj Świątek <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
@pavolloffay
Copy link
Member

@swiatekm @jaronoff97 could you please review ?

@jaronoff97 jaronoff97 merged commit fec94c8 into open-telemetry:main Oct 21, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release the operator v0.111.0
5 participants