Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use esbuild to generate layer #1602

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pragmaticivan
Copy link
Contributor

@pragmaticivan pragmaticivan commented Nov 20, 2024

Before:

Screenshot 2024-11-20 at 12 44 35 PM Screenshot 2024-11-20 at 12 45 32 PM

After:

Screenshot 2024-11-20 at 12 44 05 PM Screenshot 2024-11-20 at 12 46 24 PM

@pragmaticivan pragmaticivan marked this pull request as ready for review November 29, 2024 16:17
@pragmaticivan pragmaticivan requested a review from a team as a code owner November 29, 2024 16:17
@pragmaticivan
Copy link
Contributor Author

I might need some help testing this with an alpha layer for the esm module resolution

@pragmaticivan
Copy link
Contributor Author

It turns out that for ESM, will still need the import-in-the-middle and I the optional source maps are also missing here, although they are optional, so will only be included if the user pass a nodejs flag.

@pragmaticivan
Copy link
Contributor Author

pragmaticivan commented Dec 4, 2024

Screenshot 2024-12-04 at 5 18 49 PM

New Layer Size:

Some files are not included in the runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant