fix: remove deprecated expandconverter #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
serkan-ozal
approved these changes
Nov 6, 2024
The expandconverter is deprecated as of 0.107.0 and leaving it enabled causes issues with the parsing of environment variables. For example, when supplying an identifier like '1234' to a string field through an environment variable, this would incorrectly be treated as an integer and fail validation. Signed-off-by: Dominik Süß <[email protected]>
theSuess
force-pushed
the
fix/remove-expandconverter
branch
from
8c15315 to
7fcde1d
Compare
tylerbenson
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
expandconverteris deprecated as of 0.107.0 and leaving it enabled causes issues with the parsing of environment variables. For example, when supplying an identifier like'1234'to a string field through an environment variable, this would incorrectly be treated as an integer and fail validation.