feat(otlp-transformer)!: introduce separate entry-points for OTLP serializers #5263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
force-pushed
the
feat/add-transformer-entrypoints
branch
from
ec2720d to
176b776
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5263 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 318 318
Lines 8069 8069
Branches 1701 1701
=======================================
Hits 7632 7632
Misses 437 437
|
pichlermarc
force-pushed
the
feat/add-transformer-entrypoints
branch
from
176b776 to
2e74b8a
Compare
pichlermarc
changed the title
pichlermarc
force-pushed
the
feat/add-transformer-entrypoints
branch
2 times, most recently
from
2a53f1b to
8c1c6be
Compare
2 tasks
pichlermarc
force-pushed
the
feat/add-transformer-entrypoints
branch
from
8c1c6be to
7aca149
Compare
10 tasks
raphael-theriault-swi
approved these changes
Dec 17, 2024
pichlermarc
commented
Dec 19, 2024
chancancode
reviewed
Jan 15, 2025
| "default": "./build/src/logs/json/index.js" | ||
| } | ||
| }, | ||
| "typesVersions": { |
There was a problem hiding this comment.
These can go now that #5145 is merged, right?
chancancode
reviewed
Jan 15, 2025
chancancode
approved these changes
Jan 15, 2025
|
Hello. Any idea when this might be merged and released please? I suspect it might unblock using the package in nextJS middleware, which runs on Edge runtime, if it's enough for #4987. |
I'm still waiting on @open-telemetry/javascript-approvers reviews. Once I have an approving review this can get merged. If that happens before Feb 17, we'll release it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This is the second-to-last breaking PR for
@opentelemetry/otlp-transformerbefore marking the package as stable (#4582). This solves some issues with rollup, that warns even for code that is dead in the end-user's app. See #5096, #4987.This PR adds entry points for each signal, each signal gets an entry point for
protobufandjsonto address #5096 and #4987The new entrypoint structure is:
-
/signal,/signal/protobuf,signal/json- experimental signals are prefixed by
experimental/to allow us marking the package stable before the experimental signals are - the spec moves quicker than we do, so I expect there to always be one that is not stableCloses #5216
Closes #4584
Fixes #5096
Partially addresses #4987
Type of change
How Has This Been Tested?