Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added environment variable and increased memory limit #959

Closed
wants to merge 5 commits into from

Conversation

jordibisbal8
Copy link

@jordibisbal8 jordibisbal8 commented Nov 17, 2023

In this PR, we aim to add the environment variable LOCUST_BROWSER_TRAFFIC_ENABLED and increase the memory limit for the load generation. The main reason is to be able to run playwright in locust and generate web browser traffic. For more information, please have a look at the corresponding PR

Copy link

linux-foundation-easycla bot commented Nov 17, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@TylerHelmuth
Copy link
Member

@jordibisbal8 I believe this would be better handled by setting those values in your values.yaml

@jordibisbal8
Copy link
Author

@jordibisbal8 I believe this would be better handled by setting those values in your values.yaml

If this is part of the docker-compose and Kubernetes configuration (PR), should this not be part of the charts configuration as well? :)

@TylerHelmuth
Copy link
Member

@jordibisbal8 thanks for the new PR link, thats helpful. I agree that if they changed it in the demo repo we should change it here. Please bump the chart version and then run make generate-examples CHARTS=opentelemetry-demo.

@jordibisbal8
Copy link
Author

@jordibisbal8 thanks for the new PR link, thats helpful. I agree that if they changed it in the demo repo we should change it here. Please bump the chart version and then run make generate-examples CHARTS=opentelemetry-demo.

Done! 622dfc8
I have also run the generate-examples makefile but I do not see any changes :)

@povilasv
Copy link
Contributor

@jordibisbal8 thanks for the new PR link, thats helpful. I agree that if they changed it in the demo repo we should change it here. Please bump the chart version and then run make generate-examples CHARTS=opentelemetry-demo.

Done! 622dfc8 I have also run the generate-examples makefile but I do not see any changes :)

It should generate the new examples, as you changed the chart version. Maybe you executed make generate-examples CHARTS=opentelemetry-demo before bumping the Chart.yaml?

Can you try make generate-examples CHARTS=opentelemetry-demo again?

@jordibisbal8
Copy link
Author

jordibisbal8 commented Nov 29, 2023

@jordibisbal8 thanks for the new PR link, thats helpful. I agree that if they changed it in the demo repo we should change it here. Please bump the chart version and then run make generate-examples CHARTS=opentelemetry-demo.

Done! 622dfc8 I have also run the generate-examples makefile but I do not see any changes :)

It should generate the new examples, as you changed the chart version. Maybe you executed make generate-examples CHARTS=opentelemetry-demo before bumping the Chart.yaml?

Can you try make generate-examples CHARTS=opentelemetry-demo again?

Thanks for raising this, I was missing some helm dependencies :)
It should have worked now -> 422822b

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes correspond to a change in the demo that hasn't been released yet. I believe we'll want to wait to accept them until demo 1.7.0 is out. @puckpuck @austinlparker can you confirm?

@puckpuck
Copy link
Contributor

puckpuck commented Dec 5, 2023

Let's hold this off until we have a 1.7 release for the demo.

Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 20, 2023
@puckpuck
Copy link
Contributor

We opted not to move forward with the Playwright integration for the demo 1.7 release, so will close this PR.

@puckpuck puckpuck closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants