-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added environment variable and increased memory limit #959
Conversation
@jordibisbal8 I believe this would be better handled by setting those values in your values.yaml |
If this is part of the docker-compose and Kubernetes configuration (PR), should this not be part of the charts configuration as well? :) |
@jordibisbal8 thanks for the new PR link, thats helpful. I agree that if they changed it in the demo repo we should change it here. Please bump the chart version and then run |
Done! 622dfc8 |
It should generate the new examples, as you changed the chart version. Maybe you executed Can you try |
Thanks for raising this, I was missing some helm dependencies :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes correspond to a change in the demo that hasn't been released yet. I believe we'll want to wait to accept them until demo 1.7.0 is out. @puckpuck @austinlparker can you confirm?
Let's hold this off until we have a 1.7 release for the demo. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
We opted not to move forward with the Playwright integration for the demo 1.7 release, so will close this PR. |
In this PR, we aim to add the environment variable
LOCUST_BROWSER_TRAFFIC_ENABLED
and increase the memory limit for the load generation. The main reason is to be able to run playwright in locust and generate web browser traffic. For more information, please have a look at the corresponding PR