(demo)-collector: update prom endpoint #899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Tessier <[email protected]>
| @@ -620,7 +620,7 @@ opentelemetry-collector: | |||
| insecure: true | |||
| # Create an exporter to Prometheus (metrics) | |||
| prometheus: | |||
| endpoint: "${env.MY_POD_IP}:9464" | |||
| endpoint: ":9464" | |||
There was a problem hiding this comment.
How does this endpoint work? Is the prom chart doing some magic behind the scenes?
|
I will close this in favor of a move to the OTLP write receiver built into Prometheus instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the prometheus endpoint to use the port number only.
The prior reference to an environment variable for this property was incorrect, using
env.instead ofenv:. Removing the IP portion of the endpoint altogether makes this configuration easier to maintain.