-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set topologySpreadConstraints type to array #747
Set topologySpreadConstraints type to array #747
Conversation
Set type to array in order to match type from Kubernetes API specs: https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/#topologyspreadconstraints-field
|
@gjacquet pls sign the cla |
@Allex1 done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gjacquet can you provide a render of the new values.yaml in action? I want to make sure the deployment template doesn't need changed.
In my case it gave something like this: topologySpreadConstraints:
- labelSelector:
matchLabels:
app.kubernetes.io/instance: opentelemetry-collector
app.kubernetes.io/name: opentelemetry-collector
component: standalone-collector
maxSkew: 1
topologyKey: topology.kubernetes.io/zone
whenUnsatisfiable: ScheduleAnyway
- labelSelector:
matchLabels:
app.kubernetes.io/instance: opentelemetry-collector
app.kubernetes.io/name: opentelemetry-collector
component: standalone-collector
maxSkew: 1
topologyKey: kubernetes.io/hostname
whenUnsatisfiable: DoNotSchedule |
I would not expect any change to be required as |
Set type to array in order to match type from Kubernetes API specs: https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/#topologyspreadconstraints-field
Addresses #746