[collector] Adding K8S_NODE_IP to container env vars #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoGoat
requested review from
dmitryax,
TylerHelmuth,
povilasv and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing back the changes from #1206 PR.
As per the comments in there, replacing
K8S_NODE_NAMEwithK8S_NODE_IPmakes more sense for thekubeletstatsreceiver.Personally, I've come across the
K8S_NODE_NAMEbeing an issue in DigitalOcean managed Kubernetes cluster, and, as initially I was trying out the OTel Operator, that didn't give me an(obvious?)option to add an env variable to the final collector container.