Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] update prometheus otlp config #1462

Merged

Conversation

puckpuck
Copy link
Contributor

Updates Prometheus config for OTLP based on this guide provided in Prometheus docs.

Also fixes this issue in the demo repo.

Signed-off-by: Pierre Tessier <[email protected]>
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Should we also think about adding translation_strategy?

otlp:
  # Ingest OTLP data keeping UTF-8 characters in metric/label names.
  translation_strategy: NoUTF8EscapingWithSuffixes

https://prometheus.io/docs/guides/opentelemetry/#utf-8

I'd go for a new PR though, as all dashboards will break 🫠

@puckpuck
Copy link
Contributor Author

LGTM!

Should we also think about adding translation_strategy?

otlp:
  # Ingest OTLP data keeping UTF-8 characters in metric/label names.
  translation_strategy: NoUTF8EscapingWithSuffixes

https://prometheus.io/docs/guides/opentelemetry/#utf-8

I'd go for a new PR though, as all dashboards will break 🫠

I also considered adding this but realized it would break all dashboards, so I opted not to. This is absolutely something we should do in a future PR.

@TylerHelmuth TylerHelmuth merged commit f7f7f75 into open-telemetry:main Dec 12, 2024
3 checks passed
@puckpuck puckpuck deleted the demo.update-prometheus-otlp branch December 13, 2024 02:47
jtyr pushed a commit to jtyr/opentelemetry-helm-charts that referenced this pull request Dec 23, 2024
@Ron-Norman
Copy link

Just install chart version: 0.33.8 and it dashboards are working better but several dashboards have errors or no data. I am trying to determine what the default state should be. Build this out as training environment and want to get fully functional before we proceed to break things on out own :)

What should be working by default in a default config install? My assumption is the default install should have all metrics enabled and all dashboard panels working.

Demo Dashboard

  • No data for Spanmetrics panels
  • Application logs, both panels have errors

OpenTelemetry Collector

  • Errors on Data Flows (Error: id field is required for nodes data frame)
  • Receivers panels, not data
  • No Data for CPU Usage, Service Instance Count, Uptime by Service Instance, Service Instance Details

Opentelemetry Collector Data Flow

  • Prometheus scrape section panels are all working
  • Most of the other panels are "no data" or error state

Spanmetrics Demo Dashboard

  • all seem to be working other than "no data" on "op 7 Highest Endpoint Latencies Mean Over Range "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants