feat(opentelemetry-operator): Adding extraEnv #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiri Tyr <[email protected]>
|
We use |
Signed-off-by: Jiri Tyr <[email protected]>
jaronoff97
reviewed
Dec 12, 2024
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v2 | |||
| name: opentelemetry-operator | |||
| version: 0.75.0 | |||
| version: 0.76.0 | |||
There was a problem hiding this comment.
please bump the patch version, not the minor version. Once you've done that, please run make generate-examples CHARTS=opentelemetry-operator
There was a problem hiding this comment.
@jtyr it looks like there's no patch version bump anymore, can you do that and re-run the make generate when you can please?
Signed-off-by: Jiri Tyr <[email protected]>
Signed-off-by: Jiri Tyr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding the possibility to specify extra environment variable definitions that are not simple name/value pairs, for example when
valueFromshould be used.