[opentelemetry-kube-stack] Make hostNetwork and shareProcessNamespace… #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jaronoff97
approved these changes
Dec 6, 2024
cabrinha
force-pushed
the
if-logic-for-host-share
branch
2 times, most recently
from
8ce4f8b to
14a2703
Compare
cabrinha
force-pushed
the
if-logic-for-host-share
branch
from
14a2703 to
4667350
Compare
jaronoff97
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator wants to remove both
hostNetworkandshareProcessNamespacewhen these values arefalse, so let's help it out and make it optional.