Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentelemetry-operator): add get on nodes/proxy and nodes/stats to the clusterrole #1436

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

grandwizard28
Copy link

Fixes #1434

@grandwizard28 grandwizard28 requested review from Allex1 and a team as code owners November 29, 2024 10:14
@grandwizard28 grandwizard28 changed the title fix(opentelemetry-operator): add get on nodes/proxy and nodes/state to the clusterrole fix(opentelemetry-operator): add get on nodes/proxy and nodes/stats to the clusterrole Nov 29, 2024
@jaronoff97
Copy link
Contributor

@grandwizard28 thanks for submitting this! can you please bump the patch version of the operator chart and then run make generate-examples CHARTS=opentelemetry-operator

@grandwizard28
Copy link
Author

Done @jaronoff97

Comment on lines +108 to +119
- apiGroups:
- ""
resources:
- nodes/proxy
verbs:
- get
- apiGroups:
- ""
resources:
- nodes/stats
verbs:
- get
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaronoff97 if it is the collector that needs the permissions (I believe this is kubeletstatsreceiver or k8sattributesprocessor), why does the operator need them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comes from the operator's RBAC magic that allows it to create the necessary RBAC for the collector (getting this from the issue) I think as a result this permission should only be in the section here which contains the permissions for operator RBAC magics

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall I move it inside the createRbacPermissions block then?

@akasprzok
Copy link

Running into the same issue. Anything I can do to help here?

@jaronoff97
Copy link
Contributor

@akasprzok for now you should be able to just modify the clusterrole for the operator to include these permissions (or create a new temporary clusterrole with these permissions and bind it to the operator's SA)

@akasprzok
Copy link

@akasprzok for now you should be able to just modify the clusterrole for the operator to include these permissions (or create a new temporary clusterrole with these permissions and bind it to the operator's SA)

Yep, that works just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[operator] operator is attempting to grant RBAC permissions not currently held
4 participants