-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(opentelemetry-operator): add get on nodes/proxy and nodes/stats to the clusterrole #1436
base: main
Are you sure you want to change the base?
Conversation
…o the clusterrole
@grandwizard28 thanks for submitting this! can you please bump the patch version of the operator chart and then run |
Done @jaronoff97 |
- apiGroups: | ||
- "" | ||
resources: | ||
- nodes/proxy | ||
verbs: | ||
- get | ||
- apiGroups: | ||
- "" | ||
resources: | ||
- nodes/stats | ||
verbs: | ||
- get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaronoff97 if it is the collector that needs the permissions (I believe this is kubeletstatsreceiver or k8sattributesprocessor), why does the operator need them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall I move it inside the createRbacPermissions block then?
Running into the same issue. Anything I can do to help here? |
@akasprzok for now you should be able to just modify the clusterrole for the operator to include these permissions (or create a new temporary clusterrole with these permissions and bind it to the operator's SA) |
Yep, that works just fine. |
Fixes #1434