Fix collector label addition issue #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
reviewed
Nov 22, 2024
Comment on lines
10
to
11
|
|
||
| helm.sh/chart: opentelemetry-kube-stack-0.3.4 |
There was a problem hiding this comment.
why is this adding an extra space here?
There was a problem hiding this comment.
thanks @jaronoff97 for the review, this is fixed now.
|
Could we also change one of the examples to include some extra labels in the |
jaronoff97
approved these changes
Nov 25, 2024
|
thank you for your contribution! 🙇 |
rohanarora
pushed a commit
to rohanarora/opentelemetry-helm-charts
that referenced
this pull request
Dec 2, 2024
* fix the collector label addition failure * uptick the version * remove extra space * adding a label for demonstration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer the following issue to get more details on this PR,
closes #1426