Deploy PDB for statefulset as well as deployment #1408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infogrid-MattBuckland
requested review from
dmitryax,
TylerHelmuth,
povilasv and
a team
as code owners
povilasv
approved these changes
Nov 5, 2024
|
@Infogrid-MattBuckland you need to rebase |
On it... |
Infogrid-MattBuckland
force-pushed
the
fix/deploy-pdb-for-statefulset
branch
from
5e1fa6c to
cb0bdee
Compare
|
Think I did it right. Cheers. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see no reason not to create a podDisruptionBudget resource when deploying as a statefulset. I believe that daemonsets do not currently support PDBs so have not permitted that one at this time.
I've tested this with deployment and statefulset modes and it behaves as expected.