Allow to split the image registry and the repository #1400
Conversation
aacevedoosorio
requested review from
dmitryax,
TylerHelmuth,
povilasv and
a team
as code owners
aacevedoosorio
force-pushed
the
opentelemetry-collector-imageRegistry_imagePullSecrets
branch
4 times, most recently
from
0d1363b to
2b47c03
Compare
I ended up creating the examples. I think they are valuable |
aacevedoosorio
force-pushed
the
opentelemetry-collector-imageRegistry_imagePullSecrets
branch
from
2b47c03 to
e56b1a9
Compare
aacevedoosorio
force-pushed
the
opentelemetry-collector-imageRegistry_imagePullSecrets
branch
from
e56b1a9 to
40097ca
Compare
There was a problem hiding this comment.
@aacevedoosorio the new examples give me confidence that this process works, but I don't want to merge this PR with them. Using these options in the values.yaml is straight forward for an end-user even if the logic to build the string is kinda complex.
I get your point. Let me revert those examples. |
…mageRegistry" This reverts commit 40097ca.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@aacevedoosorio needs a rebase and then we'll be good. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
The current helm chart allows to set a
global.imageRegistryin combination with the repository configured. But it would be nice as well to split the repository into the default registry for charts that use the open-telemetry chart as a subchart and have a default predefined repository.