-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[demo] - update to 1.12 release including new flagd UI #1367
Conversation
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
@klucsik I updated your branch to work in a way that feels more natural with the rest of how the demo is setup. This changes to using an array for the |
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
I can install the chart in this PR. I can also run The differences I can see are:
|
Signed-off-by: Pierre Tessier <[email protected]>
I can help investigate this week |
I believe the issue is using |
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
@puckpuck I'll wait to merge until you approve |
…y#1367) * Add emptydir volume * Add sidecarContainer component, and add flagd-ui * flagd UI Signed-off-by: Pierre Tessier <[email protected]> * update chart, demo version and dependencies Signed-off-by: Pierre Tessier <[email protected]> * update chart, demo version and dependencies Signed-off-by: Pierre Tessier <[email protected]> * add env variables to network bind otel collector in Jaeger Signed-off-by: Pierre Tessier <[email protected]> * fix linter issue Signed-off-by: Pierre Tessier <[email protected]> * generate examples Signed-off-by: Pierre Tessier <[email protected]> * use Helm v3.14.4 Signed-off-by: Pierre Tessier <[email protected]> * update Helm prerequisite to 3.14+ Signed-off-by: Pierre Tessier <[email protected]> * use helm 3.14.4 for demo only Signed-off-by: Pierre Tessier <[email protected]> * added note about Helm version Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Pierre Tessier <[email protected]>
For deploying open-telemetry/opentelemetry-demo#1725.
The flagd-ui needs to be in the smae container with flagd so they can share an emptydir volume which containes the jsonfile for flags. flgad-ui can write it, and flagd will pick it up instanly and distributes the new flag changes.
I'm not very proficient with helm, please provide some input if this approach is fine or we can do this more neatly.
I added just a object block for the schema, would be neater to validate the entire inner block, but this is well beyond my jsonschema understanding 😃