Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] - update to 1.12 release including new flagd UI #1367

Merged
merged 18 commits into from
Nov 5, 2024

Conversation

klucsik
Copy link
Contributor

@klucsik klucsik commented Oct 4, 2024

For deploying open-telemetry/opentelemetry-demo#1725.
The flagd-ui needs to be in the smae container with flagd so they can share an emptydir volume which containes the jsonfile for flags. flgad-ui can write it, and flagd will pick it up instanly and distributes the new flag changes.
I'm not very proficient with helm, please provide some input if this approach is fine or we can do this more neatly.
I added just a object block for the schema, would be neater to validate the entire inner block, but this is well beyond my jsonschema understanding 😃

@klucsik klucsik marked this pull request as ready for review October 4, 2024 09:59
@klucsik klucsik requested review from puckpuck and a team as code owners October 4, 2024 09:59
@puckpuck puckpuck self-assigned this Oct 16, 2024
Signed-off-by: Pierre Tessier <[email protected]>
@puckpuck puckpuck changed the title Demo flagd UI [demo] - update to 1.12 release including new flagd UI Oct 18, 2024
@puckpuck
Copy link
Contributor

@klucsik I updated your branch to work in a way that feels more natural with the rest of how the demo is setup.

This changes to using an array for the sidecarContainers property. It also adds a new property called additionalVolumes at the component level, which can be used to define volumes referenced from any of the pod's container volume mounts. I also removed some schema restrictions around defining both init and sidecar containers.

@puckpuck
Copy link
Contributor

puckpuck commented Nov 5, 2024

I can install the chart in this PR. I can also run ct against it locally on my system and it works just fine, but our CI tests are failing. I could use some help to understand why our CI fails in GHA but not locally.

The differences I can see are:

  • helm version (3.16.2 locally vs 3.9.4 in GHA)
  • ct version (3.11.0 locally vs 3.10.1 in GHA)
  • environment (MacOS locally vs Linux in GHA)

@TylerHelmuth
Copy link
Member

I can help investigate this week

@TylerHelmuth
Copy link
Member

I believe the issue is using tpl inside range: helm/helm#5979. @puckpuck @klucsik can you update the Setup step in .github/workflows/lint.yaml and .github/workflows/demo-test.yaml to use helm 3.14.4

Signed-off-by: Pierre Tessier <[email protected]>
@TylerHelmuth
Copy link
Member

@puckpuck I'll wait to merge until you approve

@TylerHelmuth TylerHelmuth merged commit 9663cc6 into open-telemetry:main Nov 5, 2024
3 checks passed
codeboten pushed a commit to codeboten/opentelemetry-helm-charts that referenced this pull request Nov 14, 2024
…y#1367)

* Add emptydir volume

* Add sidecarContainer component, and add flagd-ui

* flagd UI

Signed-off-by: Pierre Tessier <[email protected]>

* update chart, demo version and dependencies

Signed-off-by: Pierre Tessier <[email protected]>

* update chart, demo version and dependencies

Signed-off-by: Pierre Tessier <[email protected]>

* add env variables to network bind otel collector in Jaeger

Signed-off-by: Pierre Tessier <[email protected]>

* fix linter issue

Signed-off-by: Pierre Tessier <[email protected]>

* generate examples

Signed-off-by: Pierre Tessier <[email protected]>

* use Helm v3.14.4

Signed-off-by: Pierre Tessier <[email protected]>

* update Helm prerequisite to 3.14+

Signed-off-by: Pierre Tessier <[email protected]>

* use helm 3.14.4 for demo only

Signed-off-by: Pierre Tessier <[email protected]>

* added note about Helm version

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Co-authored-by: Pierre Tessier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants