move prometheus exporter config to use readers #1337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the configuration to use metric readers configuration instead of the deprecated `address` configuration. Signed-off-by: Alex Boten <[email protected]>
TylerHelmuth
reviewed
Sep 9, 2024
Comment on lines
140
to
145
| readers: | ||
| - pull: | ||
| exporter: | ||
| prometheus: | ||
| host: ${env:MY_POD_IP} | ||
| port: 8888 |
There was a problem hiding this comment.
This will be equivalent for anyone who is not configuring config.service.telemetry.metrics.address but what will happen if someone has done something like --set config.service.telemetry.metrics.address=${env:MY_POD_IP}:9090?
There was a problem hiding this comment.
there would be 2 prometheus ports exposed in that case
There was a problem hiding this comment.
We should introduce a template in config that will build the reader yaml from .Values.config.service.telemetry.metrics.address if it is set and otherwise use .Values.config.service.telemetry.metrics.readers.
Signed-off-by: Alex Boten <[email protected]>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Can someone reopen this please 😬 |
…try-kube-stack.labels (open-telemetry#1363) * fix: Add missing release label to opentelemetry-kube-stack.labels * [opentelemetry-kube-stack] Bump to v0.2.2 and regenerate examples
…allowed" error while adding selector label to service (open-telemetry#1370) * [opentelemetry-kube-stack]: Fix "Additional property selector is not allowed" error while adding selector label to service
…metry#1373) Bumps [kyverno/action-install-chainsaw](https://github.com/kyverno/action-install-chainsaw) from 0.2.10 to 0.2.11. - [Release notes](https://github.com/kyverno/action-install-chainsaw/releases) - [Commits](kyverno/action-install-chainsaw@v0.2.10...v0.2.11) --- updated-dependencies: - dependency-name: kyverno/action-install-chainsaw dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* bump to 109 * bump again
…y#1384) * [kube-stack] Bump opentelemetry-operator chart to 0.71 * chore: bump chart version * update operator crds * ci: bump python version
* Fix volume and mount indentation * make
…ok (open-telemetry#1391) * Fix Collector CRD referencing non-existing service due to webhooks disabled * [chore] Bump chart version and generate examples * Revert "[chore] Bump chart version and generate examples" This reverts commit 26277e6. * [chore] Generate Examples For OTEL Operator Only * [fix] Fix test failure due to bundle CRDs diff due to webhook templating * [chore] Make diff output silent again
…mediate vulnerabilities (open-telemetry#1397) * [opentelemetry-operator] Update kube-rbac-proxy image from 0.15.0 to 0.18.1 Signed-off-by: Edwin Tye <[email protected]> * [opentelemetry-operator] remove argument logtostderr as it no longer has effect since 0.16.0 Signed-off-by: Edwin Tye <[email protected]> --------- Signed-off-by: Edwin Tye <[email protected]>
…try#1395) * docs: docs: adjust a description error in NOTES.txt file * fix: bump the patch version of the operator Chart.yaml
* Bump operator to v0.111.0 * make crds * fix crd * regenerate examples * Fix crd generation and checking
…y#1367) * Add emptydir volume * Add sidecarContainer component, and add flagd-ui * flagd UI Signed-off-by: Pierre Tessier <[email protected]> * update chart, demo version and dependencies Signed-off-by: Pierre Tessier <[email protected]> * update chart, demo version and dependencies Signed-off-by: Pierre Tessier <[email protected]> * add env variables to network bind otel collector in Jaeger Signed-off-by: Pierre Tessier <[email protected]> * fix linter issue Signed-off-by: Pierre Tessier <[email protected]> * generate examples Signed-off-by: Pierre Tessier <[email protected]> * use Helm v3.14.4 Signed-off-by: Pierre Tessier <[email protected]> * update Helm prerequisite to 3.14+ Signed-off-by: Pierre Tessier <[email protected]> * use helm 3.14.4 for demo only Signed-off-by: Pierre Tessier <[email protected]> * added note about Helm version Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Pierre Tessier <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
This reverts commit c3699879da7e12e3e2a2a708705e505693369903.
This reverts commit d04deafd03fd42b32fd44e42b1e0da0523b7cf32.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the configuration to use metric readers configuration instead of the deprecated
addressconfiguration.