[collector] Remove the deprecated memory ballast extension #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
jaronoff97
approved these changes
Jul 22, 2024
mx-psi
added a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Sep 4, 2024
…10671) #### Description This PR removes the deprecated memory ballast extension and all the logic in place in memorylimiter and service that was using it. #### Link to tracking issue Related to #8343. I don't want to close it until the [helm chart](open-telemetry/opentelemetry-helm-charts#1268) is updated. #### Testing Unit tests --------- Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Curtis Robert <[email protected]> Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the memory ballast extension from the default configuration.
I opted to leave
useGOMEMLIMITin place because some users may want to define the value manually.Related to open-telemetry/opentelemetry-collector#8343