-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[collector] feat: add 'relabelings' and 'metricRelabelings' configs to serviceMonitor #1245
[collector] feat: add 'relabelings' and 'metricRelabelings' configs to serviceMonitor #1245
Conversation
…itor Signed-off-by: Ryan Lonergan <[email protected]>
Signed-off-by: Ryan Lonergan <[email protected]>
Signed-off-by: Ryan Lonergan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to continue discussing in the issue before implementing the relableing solution. I believe the Collector already has a solution.
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@TylerHelmuth any updates on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix conflicts
you'll also need to run |
done, updated examples have been pushed up |
…o serviceMonitor (open-telemetry#1245) * feat: add 'relabelings' and 'metricRelabelings' configs to serviceMonitor Signed-off-by: Ryan Lonergan <[email protected]> * update schema Signed-off-by: Ryan Lonergan <[email protected]> * update version in Chart.yaml Signed-off-by: Ryan Lonergan <[email protected]> * bump Chart version * chore: make generate-examples CHARTS=opentelemetry-collector --------- Signed-off-by: Ryan Lonergan <[email protected]>
Adds the ability to add relabeling and metricRelabeling configs to the collector serviceMonitor created by the opentelemetry-collector helm chart. Resolves #1240