Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[collector] feat: add 'relabelings' and 'metricRelabelings' configs to serviceMonitor #1245

Merged

Conversation

rl0nergan
Copy link
Contributor

Adds the ability to add relabeling and metricRelabeling configs to the collector serviceMonitor created by the opentelemetry-collector helm chart. Resolves #1240

@rl0nergan rl0nergan requested a review from a team July 2, 2024 16:16
rl0nergan added 2 commits July 2, 2024 12:43
Signed-off-by: Ryan Lonergan <[email protected]>
Signed-off-by: Ryan Lonergan <[email protected]>
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to continue discussing in the issue before implementing the relableing solution. I believe the Collector already has a solution.

Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 17, 2024
@rl0nergan
Copy link
Contributor Author

@TylerHelmuth any updates on this?

@github-actions github-actions bot removed the Stale label Jul 18, 2024
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix conflicts

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 18, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 18, 2024
@TylerHelmuth
Copy link
Member

you'll also need to run make generate-examples CHARTS=opentelemetry-collector

@rl0nergan
Copy link
Contributor Author

done, updated examples have been pushed up

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 19, 2024
@TylerHelmuth TylerHelmuth merged commit 86e1eb2 into open-telemetry:main Jul 19, 2024
3 checks passed
@rl0nergan rl0nergan deleted the collector/relabeling-configs branch July 19, 2024 15:56
12ushan pushed a commit to giffgaff/opentelemetry-helm-charts that referenced this pull request Jul 22, 2024
…o serviceMonitor (open-telemetry#1245)

* feat: add 'relabelings' and 'metricRelabelings' configs to serviceMonitor

Signed-off-by: Ryan Lonergan <[email protected]>

* update schema

Signed-off-by: Ryan Lonergan <[email protected]>

* update version in Chart.yaml

Signed-off-by: Ryan Lonergan <[email protected]>

* bump Chart version

* chore: make generate-examples CHARTS=opentelemetry-collector

---------

Signed-off-by: Ryan Lonergan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[helm chart] Add 'relabelings' option to serviceMonitor
3 participants