[collector] Separate command and args #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2024
|
@TylerHelmuth is any e2e testing run this for chart? i.e. are we positive data is flowing through the collector if the tests are passing? I didn't see any indication of that from the test logs |
|
@jaronoff97 no the ci folder only tests that the chart is installable (the pod starts up). I did test locally (and I shouldve put that in the description)
|
jaronoff97
approved these changes
Apr 19, 2024
JaredTan95
approved these changes
Apr 19, 2024
12ushan
pushed a commit
to giffgaff/opentelemetry-helm-charts
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the
commandsection into bothcommandandargs. When acommand.nameis provided it will get set, overriding theENTRYPOINTin the container.argsworks withcommandwhen it is provided, otherwise they are passed to theentrypoint.Since our default command name is the same as the default image's
ENTRYPOINT, removing it is a non-breaking change.Related to #1148