[collector] support tpl in extraContainers #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredTan95
requested review from
dmitryax,
TylerHelmuth and
povilasv
as code owners
TylerHelmuth
approved these changes
Apr 16, 2024
JaredTan95
added a commit
to JaredTan95/opentelemetry-helm-charts
that referenced
this pull request
Apr 16, 2024
TylerHelmuth
added a commit
that referenced
this pull request
Apr 16, 2024
* fix #1139 * update * revert examples changes * Update charts/opentelemetry-collector/examples/daemonset-and-deployment/deployment-values.yaml --------- Co-authored-by: Tyler Helmuth <[email protected]>
blumamir
added a commit
to odigos-io/odigos
that referenced
this pull request
Apr 17, 2024
It was introduced as a workaround fix until open-telemetry/opentelemetry-helm-charts#1143 is merged, due to an bug introduced via open-telemetry/opentelemetry-helm-charts#1139 which broke odigos ci
This was referenced Jun 27, 2024
12ushan
pushed a commit
to giffgaff/opentelemetry-helm-charts
that referenced
this pull request
Jul 22, 2024
12ushan
pushed a commit
to giffgaff/opentelemetry-helm-charts
that referenced
this pull request
Jul 22, 2024
…ry#1143) * fix open-telemetry#1139 * update * revert examples changes * Update charts/opentelemetry-collector/examples/daemonset-and-deployment/deployment-values.yaml --------- Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as #570, support tpl in extraContainers.