Add Bridge to opentelemetry-kube-stack #1138
Conversation
|
Seeing this PR, I thought of a digression. As we all know, helm won't apply the crd in the I see this and this PR both include crd content, will there be the same problem? |
|
the way around this is to include crds in the templates directory, it's a hack but is kind of the only thing that can be done to resolve this effectively. You can see an example of me doing this to handle updates here though idk if that's how we want to do all of this. Either way, we should probably discuss this not in this PR but rather in an issue or in slack |
|
Yes, I actually know that there will be no problem with this PR, but I think it is a little strange, maybe it is the hack way you said. But overall for me, lgtm. |
…y-helm-charts into 1079-make-bridge
* add bridge in * match name of bridge * updates from feedback * envfromfirst --------- Co-authored-by: Jared Tan <[email protected]>
Closes #1079
This PR adds the ability to create an opamp bridge as part of the chart. This creates the bridge and its clusterroles/bindings as well as convenience for adding the necessary labels when applicable for the collector.