[collector] Make it possible to mount configMap by chart name #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunter0
requested review from
dmitryax,
TylerHelmuth and
povilasv
as code owners
|
|
|
@chunter0 it isn't clear to me how this field is different than |
|
Opened an issue here for discussion |
|
@open-telemetry/helm-approvers please review |
chunter0
force-pushed
the
chunter/configmap-mount-option
branch
from
57b7eb8 to
852e551
Compare
|
I commented on the issue |
Co-authored-by: Tyler Helmuth <[email protected]>
povilasv
reviewed
Apr 24, 2024
jaronoff97
approved these changes
Apr 24, 2024
povilasv
approved these changes
Apr 25, 2024
TylerHelmuth
approved these changes
Apr 25, 2024
12ushan
pushed a commit
to giffgaff/opentelemetry-helm-charts
that referenced
this pull request
Jul 22, 2024
…elemetry#1105) * update with configMap field with mount option * update comment * update schema * change name to `includeMount` * bump version * re-generate examples * use existingName field instead * Merge remote-tracking branch 'upstream/main' into chunter/configmap-mount-option * update comment and move logic to template * Apply suggestions from code review Co-authored-by: Tyler Helmuth <[email protected]> * safe-guard configMap creation * add configMap error message --------- Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
configMap.mountfield which can be used to control mounting the configMap by chart name. This new field is helpful when using opentelemetry-collector as a subchart it will allow users the ability to create their own configuration and still have the configMap mounted under the default schema.