Remove required container resources (#1312)

* remove resource requirements * allow additional properties in limits and requests * bump chart version * update examples
open-telemetry · Aug 21, 2024 · 5da61e9 · 5da61e9
1 parent 96fc70a
commit 5da61e9
Show file tree

Hide file tree

Showing 13 changed files with 27 additions and 41 deletions.
diff --git a/charts/opentelemetry-operator/Chart.yaml b/charts/opentelemetry-operator/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: opentelemetry-operator
-version: 0.68.0
+version: 0.68.1
 description: OpenTelemetry Operator Helm chart for Kubernetes
 type: application
 home: https://opentelemetry.io/

diff --git a/...ator/examples/default/rendered/admission-webhooks/operator-webhook-with-cert-manager.yaml b/...ator/examples/default/rendered/admission-webhooks/operator-webhook-with-cert-manager.yaml
@@ -6,7 +6,7 @@ metadata:
   annotations:
     cert-manager.io/inject-ca-from: default/example-opentelemetry-operator-serving-cert
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm
@@ -91,7 +91,7 @@ metadata:
   annotations:
     cert-manager.io/inject-ca-from: default/example-opentelemetry-operator-serving-cert
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm

diff --git a/charts/opentelemetry-operator/examples/default/rendered/certmanager.yaml b/charts/opentelemetry-operator/examples/default/rendered/certmanager.yaml
@@ -4,7 +4,7 @@ apiVersion: cert-manager.io/v1
 kind: Certificate
 metadata:
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm
@@ -30,7 +30,7 @@ apiVersion: cert-manager.io/v1
 kind: Issuer
 metadata:
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm

diff --git a/charts/opentelemetry-operator/examples/default/rendered/clusterrole.yaml b/charts/opentelemetry-operator/examples/default/rendered/clusterrole.yaml
@@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm
@@ -223,7 +223,7 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm
@@ -242,7 +242,7 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm

diff --git a/charts/opentelemetry-operator/examples/default/rendered/clusterrolebinding.yaml b/charts/opentelemetry-operator/examples/default/rendered/clusterrolebinding.yaml
@@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm
@@ -26,7 +26,7 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm

diff --git a/charts/opentelemetry-operator/examples/default/rendered/deployment.yaml b/charts/opentelemetry-operator/examples/default/rendered/deployment.yaml
@@ -4,7 +4,7 @@ apiVersion: apps/v1
 kind: Deployment
 metadata:
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm

diff --git a/charts/opentelemetry-operator/examples/default/rendered/role.yaml b/charts/opentelemetry-operator/examples/default/rendered/role.yaml
@@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm

diff --git a/charts/opentelemetry-operator/examples/default/rendered/rolebinding.yaml b/charts/opentelemetry-operator/examples/default/rendered/rolebinding.yaml
@@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm

diff --git a/charts/opentelemetry-operator/examples/default/rendered/service.yaml b/charts/opentelemetry-operator/examples/default/rendered/service.yaml
@@ -4,7 +4,7 @@ apiVersion: v1
 kind: Service
 metadata:
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm
@@ -32,7 +32,7 @@ apiVersion: v1
 kind: Service
 metadata:
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm

diff --git a/charts/opentelemetry-operator/examples/default/rendered/serviceaccount.yaml b/charts/opentelemetry-operator/examples/default/rendered/serviceaccount.yaml
@@ -6,7 +6,7 @@ metadata:
   name: opentelemetry-operator
   namespace: default
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm

diff --git a/...s/opentelemetry-operator/examples/default/rendered/tests/test-certmanager-connection.yaml b/...s/opentelemetry-operator/examples/default/rendered/tests/test-certmanager-connection.yaml
@@ -6,7 +6,7 @@ metadata:
   name: "example-opentelemetry-operator-cert-manager"
   namespace: default
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm

diff --git a/charts/opentelemetry-operator/examples/default/rendered/tests/test-service-connection.yaml b/charts/opentelemetry-operator/examples/default/rendered/tests/test-service-connection.yaml
@@ -6,7 +6,7 @@ metadata:
   name: "example-opentelemetry-operator-metrics"
   namespace: default
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm
@@ -44,7 +44,7 @@ metadata:
   name: "example-opentelemetry-operator-webhook"
   namespace: default
   labels:
-    helm.sh/chart: opentelemetry-operator-0.68.0
+    helm.sh/chart: opentelemetry-operator-0.68.1
     app.kubernetes.io/name: opentelemetry-operator
     app.kubernetes.io/version: "0.107.0"
     app.kubernetes.io/managed-by: Helm

diff --git a/charts/opentelemetry-operator/values.schema.json b/charts/opentelemetry-operator/values.schema.json
@@ -131,7 +131,6 @@
                 "autoInstrumentationImage",
                 "featureGates",
                 "ports",
-                "resources",
                 "env",
                 "serviceAccount",
                 "serviceMonitor",
@@ -564,18 +563,15 @@
                     "type": "object",
                     "default": {},
                     "title": "The resources Schema",
-                    "required": [
-                        "limits",
-                        "requests"
-                    ],
+                    "required": [],
                     "additionalProperties": false,
                     "properties": {
                         "limits": {
                             "type": "object",
                             "default": {},
                             "title": "The limits Schema",
                             "required": [],
-                            "additionalProperties": false,
+                            "additionalProperties": true,
                             "properties": {
                                 "cpu": {
                                     "type": "string",
@@ -611,11 +607,8 @@
                             "type": "object",
                             "default": {},
                             "title": "The requests Schema",
-                            "required": [
-                                "cpu",
-                                "memory"
-                            ],
-                            "additionalProperties": false,
+                            "required": [],
+                            "additionalProperties": true,
                             "properties": {
                                 "cpu": {
                                     "type": "string",
@@ -1198,7 +1191,6 @@
                 "enabled",
                 "image",
                 "ports",
-                "resources",
                 "extraArgs",
                 "securityContext"
             ],
@@ -1270,18 +1262,15 @@
                     "type": "object",
                     "default": {},
                     "title": "The resources Schema",
-                    "required": [
-                        "limits",
-                        "requests"
-                    ],
+                    "required": [],
                     "additionalProperties": false,
                     "properties": {
                         "limits": {
                             "type": "object",
                             "default": {},
                             "title": "The limits Schema",
                             "required": [],
-                            "additionalProperties": false,
+                            "additionalProperties": true,
                             "properties": {
                                 "cpu": {
                                     "type": "string",
@@ -1309,11 +1298,8 @@
                             "type": "object",
                             "default": {},
                             "title": "The requests Schema",
-                            "required": [
-                                "cpu",
-                                "memory"
-                            ],
-                            "additionalProperties": false,
+                            "required": [],
+                            "additionalProperties": true,
                             "properties": {
                                 "cpu": {
                                     "type": "string",