Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] Refactor shared protobuf otlp export client code into a base class #6001

Conversation

CodeBlanch
Copy link
Member

Changes

  • Introduce a base class for ProtobufOtlpGrpcExportClient & ProtobufOtlpHttpExportClient to share to reduce code duplication
  • Add a comment explaining why ProtobufOtlpGrpcExportClient doesn't try to do synchronous send

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team as a code owner November 26, 2024 23:13
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.07%. Comparing base (88d2ad6) to head (d5c4aee).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ation/ExportClient/ProtobufOtlpGrpcExportClient.cs 44.44% 5 Missing ⚠️
...mentation/ExportClient/ProtobufOtlpExportClient.cs 97.05% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6001      +/-   ##
==========================================
+ Coverage   85.02%   85.07%   +0.05%     
==========================================
  Files         275      276       +1     
  Lines       12710    12693      -17     
==========================================
- Hits        10807    10799       -8     
+ Misses       1903     1894       -9     
Flag Coverage Δ
unittests-Project-Experimental 85.03% <86.66%> (+0.02%) ⬆️
unittests-Project-Stable 84.90% <86.66%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ation/ExportClient/ProtobufOtlpHttpExportClient.cs 82.35% <100.00%> (-8.56%) ⬇️
...mentation/ExportClient/ProtobufOtlpExportClient.cs 97.05% <97.05%> (ø)
...ation/ExportClient/ProtobufOtlpGrpcExportClient.cs 37.93% <44.44%> (-11.62%) ⬇️

... and 3 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 7eeddf5 into open-telemetry:main Nov 27, 2024
35 checks passed
@CodeBlanch CodeBlanch deleted the oltp-refactor-protobufotlpexportclient branch November 27, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants