Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] boost_log compilation error (possibly dangling reference) #440

Merged
merged 1 commit into from
May 20, 2024
Merged

[BUILD] boost_log compilation error (possibly dangling reference) #440

merged 1 commit into from
May 20, 2024

Conversation

marcalff
Copy link
Member

Fixes #439

@marcalff marcalff marked this pull request as ready for review May 10, 2024 14:45
@marcalff marcalff requested a review from a team May 10, 2024 14:45
@marcalff marcalff added pr:please-review This PR is ready for review instrumentation:boost-log Boost-log log appender labels May 10, 2024
@marcalff
Copy link
Member Author

@lalitb @ThomsonTan @esigo Please review

esigo
esigo approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks for the fix

@marcalff marcalff merged commit 0ca45bd into open-telemetry:main May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esigo esigo esigo approved these changes

Assignees
No one assigned
Labels
instrumentation:boost-log Boost-log log appender pr:please-review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUILD] boost_log compilation error (possibly dangling reference)
2 participants
@marcalff @esigo