Otel webserver samplers #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, this sampling feature for apache modules is in high demand, can we get a code review and a PR acceptance please? |
|
@DebajitDas @kpratyus Can someone help here? |
|
Hey @starDigger, the build were not triggered. Could you please re-push the code so that the builds can be triggered and we can merge it. |
|
Hey, can you pull the code again and push your changes. Some builds were failing, so changes have been made to the build pipeline. |
marcalff
added
the
Webserver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 4 samplers to the otel-webserver-module: traceidratio, parentbased_always_on, parentbased_always_off, and parentbased_traceidratio. Added Conf file parameter for Sampler Ratio. Fixed README to correctly reflect what sampler options exist within the code base.
Resolves #ticket_number 273 and closes out some //TODO's in main branch.