[chore] refactor(contrib): remove unused replace directive for go-connections package
#677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnections` package The package `github.com/docker/go-connections` only exists in contrib's generated `go.mod` file in version `v0.5.0`, and does not exist in the replaced version `v0.4.1`. The distro also builds and runs fine without the replace directive. I believe the [reason](open-telemetry/opentelemetry-collector-contrib#12322 (comment)) for the replace directive to have been added is out of date. To be sure, I have run the repro scenario described [here](docker/go-connections#99 (comment)) and the behavior with go-connections v0.5.0 was correct - the Docker client tried to connect to the TCP port.
songy23
approved these changes
Sep 27, 2024
codeboten
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
This looks ok, removing the same replace in contrib open-telemetry/opentelemetry-collector-contrib#35554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package
github.com/docker/go-connectionsonly exists in contrib's generatedgo.modfile in versionv0.5.0, and does not exist in the replaced versionv0.4.1. The distro also builds and runs fine without the replace directive.I believe the reason for the replace directive to had been added is out of date. To be sure, I have run the repro scenario described here and the behavior with go-connections v0.5.0 was correct - the Docker client tried to connect to the TCP port.