[connector/datadog] support obfuscation in datadogconnector #37457
+275
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
IbraheemA,
jade-guiton-dd,
liustanley,
mackjmr,
mx-psi and
songy23
jackgopack4
changed the title
songy23
reviewed
Jan 23, 2025
songy23
reviewed
Jan 23, 2025
jackgopack4
force-pushed
the
jackgopack4/datadogconnector-obfuscate
branch
2 times, most recently
from
89a1c0e to
187eb6f
Compare
github-actions
bot
added
cmd/otelcontribcol
|
looks like replacing the dependency in otelcontribcol fixes it; going to see if I can remove the replace in awscontainerinsight and still pass checks |
jackgopack4
force-pushed
the
jackgopack4/datadogconnector-obfuscate
branch
2 times, most recently
from
ab3d832 to
881f253
Compare
|
@songy23 if these checks pass, can you remove the receiver/awscontainerinsight label? |
songy23
reviewed
Jan 24, 2025
songy23
reviewed
Jan 24, 2025
jackgopack4
force-pushed
the
jackgopack4/datadogconnector-obfuscate
branch
from
bfbcde5 to
98616a2
Compare
songy23
approved these changes
Jan 24, 2025
|
thanks, @songy23! |
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…emetry#37457) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Support obfuscating SQL and Redis queries in APM stats in Datadog Connector. replace statement in otelcontribcol was necessary due to failing build in pipeline. It doesn't appear that any modules use any affected functions, but building otelcontribcol with ocb failed due to an API change. Also opened an issue to bump the `receiver/awscontainerinsight` dependency so that this replace can be removed in the future: open-telemetry#37486 <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Replaces open-telemetry#35401 <!--Describe what testing was performed and which tests were added.--> #### Testing Added TestObfuscate in connector_native_test.go <!--Describe the documentation added.--> #### Documentation added release note and link to semantics on Datadog vendor website <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support obfuscating SQL and Redis queries in APM stats in Datadog Connector.
replace statement in otelcontribcol was necessary due to failing build in pipeline. It doesn't appear that any modules use any affected functions, but building otelcontribcol with ocb failed due to an API change. Also opened an issue to bump the
receiver/awscontainerinsightdependency so that this replace can be removed in the future: #37486Link to tracking issue
Replaces #35401
Testing
Added TestObfuscate in connector_native_test.go
Documentation
added release note and link to semantics on Datadog vendor website