[connector/routing] Fix configuration error with request context #37411
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
samiura
approved these changes
Jan 23, 2025
|
Sounds good. Please add a changelog and a unit test. |
vlaborie
force-pushed
the
main
branch
2 times, most recently
from
c38af91 to
af7932f
Compare
Remove a residual fallthrough keyword Fixes open-telemetry#37410 Added unit tests for valid request context. Updated changelog.
@atoulme I just add a changelog entry and a unit test for valid request context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove a residual fallthrough keyword which induce a configuration error
Link to tracking issue
Fixes #37410