[pkg/ottl] add event_index to available paths in span event context #37092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
…nto feat/35778/ottl-event-index
Signed-off-by: Florian Bacher <[email protected]>
evan-bradley
reviewed
Jan 9, 2025
Co-authored-by: Evan Bradley <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
# Conflicts: # pkg/ottl/contexts/ottlspanevent/span_events.go
edmocosta
reviewed
Jan 16, 2025
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
added
processor/tailsampling
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
| func accessSpanEventIndex() ottl.StandardGetSetter[TransformContext] { | ||
| return ottl.StandardGetSetter[TransformContext]{ | ||
| Getter: func(_ context.Context, tCtx TransformContext) (any, error) { | ||
| return tCtx.eventIndex, nil |
There was a problem hiding this comment.
Maybe instead of checking for negative values in the Option the getter should check and return an error if it finds one.
Also might be good to be able to indicate if the user set the value and if they didn't, error. We dont want to return a default 0 incorrectly.
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
event_indexto the available paths in the span event contextLink to tracking issue
Fixes #35778
Testing
Unit tests, e2e tests
Documentation
added an entry in the list of available paths in the readme of then span event context