[chore] don't reference testutil from non-test code #37090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
andrzej-stencel,
Aneurysm9,
atoulme,
crobert-1,
djaglowski,
dmitryax,
jacobmarble,
JaredTan95,
mar4uk,
MovieStoreGuy,
srprash,
wangzlei and
yurishkuro
axw
force-pushed
the
receiver-factory-no-testutil
branch
2 times, most recently
from
9a83df2 to
0fe1bbb
Compare
axw
changed the title
axw
force-pushed
the
receiver-factory-no-testutil
branch
from
0fe1bbb to
2101373
Compare
Update various receiver factories to stop using testutil.EndpointForPort, and directly specify the default endpoint.
axw
force-pushed
the
receiver-factory-no-testutil
branch
from
2101373 to
3f7af72
Compare
crobert-1
approved these changes
Jan 8, 2025
codeboten
approved these changes
Jan 8, 2025
| @@ -22,8 +21,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| defaultEndpoint = "0.0.0.0:4433" | |||
There was a problem hiding this comment.
im surprised the linters weren't complaining about defaultEndpoint not being used before 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update various receiver factories to stop using testutil.EndpointForPort, and directly specify the default endpoint. This removes test-related packages from the main binary's dependency tree.
Link to tracking issue
N/A
Testing
N/A
Documentation
N/A