[chore] pkg/stanza: move test code to new syslogtest package #37089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While looking at the syslog code I noticed that data.go contains test-only code, but was not defined in a _test.go file.
|
Maybe I didn't look hard enough for references... :) |
axw
changed the title
axw
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37089 +/- ##
==========================================
+ Coverage 79.61% 79.66% +0.04%
==========================================
Files 2223 2244 +21
Lines 210283 211266 +983
==========================================
+ Hits 167417 168303 +886
- Misses 37250 37347 +97
Partials 5616 5616 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While looking at the stanza syslog parser code I noticed that data.go contains test-only code, but was not defined in a test package. Moving it to a separate test package means the API of the main code will not be polluted.
Link to tracking issue
None
Testing
N/A
Documentation
N/A