[processor/k8sattributes] update internally stored pods with replicaset/deployment information #37088
+206
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
requested review from
ChrsMark,
dmitryax,
fatsheep9146 and
TylerHelmuth
Signed-off-by: Florian Bacher <[email protected]>
bacherfl
changed the title
Signed-off-by: Florian Bacher <[email protected]>
ChrsMark
reviewed
Jan 8, 2025
| @@ -1095,6 +1096,26 @@ func (c *WatchClient) addOrUpdateReplicaSet(replicaset *apps_v1.ReplicaSet) { | |||
| c.ReplicaSets[string(replicaset.UID)] = newReplicaSet | |||
| } | |||
| c.m.Unlock() | |||
|
|
|||
| for _, pod := range c.Pods { | |||
There was a problem hiding this comment.
If we can avoid looping over Pod's cache by waiting for all of the syncs to happen first that would be great. Left a comment back at the issue: #37056 (comment)
There was a problem hiding this comment.
Thanks for the initial review @ChrsMark! Currently the issue also with the wait_for_metadata is that during the initial sync, the pods already present in the system can arrive at the informer before their replicasets. However maybe there is a way to first wait for the initial replicaSet informer sync to be complete, before proceeding with the pod informer. I will try to see if this can be done, as I'm also not quite happy with the current solution of iterating over all pods yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adapts the k8sattributes processor to update its internally stored pods with the information about their respective replica sets and deployments, after the replica set information is received via the informer.
This can happen during the initial sync of the processor, where it can happen that the replica set information for existing pods is received after the pods have already been received and stored internally.
Link to tracking issue
Fixes #37056
Testing
Added unit test
Documentation